Ingress trait not creating the hostname : rudr 0.1.0

[sowsan]

rudr version: 0.1.0

helm version:
version.BuildInfo{Version:"v3.0.1", GitCommit:"7c22ef9ce89e0ebeb7125ba2ebf7d421f3e82ffa", GitTreeState:"clean", GoVersion:"go1.13.4"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:36:53Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.12", GitCommit:"524c3a1238422529d62f8e49506df658fa9c8b8c", GitTreeState:"clean", BuildDate:"2019-11-14T05:26:24Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
AKS and GKE

An application installed with a trait for ingress is not creating with the assigned hostname.

Using the Nginx Ingress Controller, everything was working fine till last week.

Tried with both samples listed here : https://github.com/oam-dev/samples

[resouer]

/cc @wonderflow @hongchaodeng is this related to the Trait name change recently?

[resouer]

ref: #516

[hongchaodeng]

Hi @sowsan

Thanks for reporting the issue. I apologized for the delay in replying.

The sample's traits are outdated. Since #516 , all the traits have been changed to object style mapping.

Here's a comparison:

# old
    traits:
      - name: ingress
        parameterValues:
          - name: hostname
            value: servicetracker.oam.io
          - name: path
            value: / 
          - name: service_port
            value: 8080     
---
# new
      traits:
        - name: ingress
          properties:
            hostname: example.com
            path: /
            servicePort: 9999

Would you update the samples?

[sowsan]

Thanks, sure I will change it. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Hongchao Deng <[email protected]> Sent: Thursday, January 23, 2020 2:33:07 AM To: oam-dev/rudr <[email protected]> Cc: sowmyan soman <[email protected]>; Mention <[email protected]> Subject: Re: [oam-dev/rudr] Ingress trait not creating the hostname : rudr 0.1.0 (#519) Hi @sowsan<https://github.com/sowsan> Thanks for reporting the issue. I apologized for the delay in replying. The sample's traits are outdated. Since #516<#516> , all the traits have been changed to object style mapping. Here's a comparison: # old traits: - name: ingress parameterValues: - name: hostname value: servicetracker.oam.io - name: path value: / - name: service_port value: 8080 --- # new traits: - name: ingress properties: hostname: example.com path: / servicePort: 9999 Would you update the samples? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#519?email_source=notifications&email_token=ACYCMWN4D4INDVRAR64SHFLQ7FB3HA5CNFSM4KJYNBH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJWKTRQ#issuecomment-577546694>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACYCMWIFGEYGGVTH2L7NNZ3Q7FB3HANCNFSM4KJYNBHQ>.

[sowsan]

Can we add metadata to the ApplicationConfiguration to tie with a specific rudr runtime version or a range of rudr runtime version to avoid these kinds of issues in the future? So, if anyone deploys an app using the ApplicationConfiguration it will validate with the rudr runtime and if the specified runtime version is not installed the k8s cluster it won't install the app and notify the user. Thoughts?

[sowsan]

Fixed this in all samples and created a pull request here: kubevela/samples#25

Thank you so much to @wdfox for testing and verifying these changes with me.

[hongchaodeng]

@sowsan
Yeah. Adding a range of version to AppConfig's annotations would be good. But hard enforcing it in Rudr side is not a concern of now. Could you create an issue for compatibility concern and we could revisit it in GA or Beta release.