fix: Use a static time period in test_coops_data_products_w_date_input()
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_coops_data_products_w_date_input(days_before_end, station_id, product): | ||
| # 2024-02-05 was the date when the test was added. | ||
| # This ensures that the test can continue to run in the future | ||
| end_date = pd.Timestamp("2024-02-05", tz="UTC") |
There was a problem hiding this comment.
@pmav99 I think at the time I wrote these, there were some limitations on how much back in time the data is available for certain products, so I decided to always use now and then go back a much as data is available, or something close to that.
There was a problem hiding this comment.
I see. In that case I think we need to either make the test more lenient e.g. to skip or xfail if the station has no data or use a cassette.
I will close the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.