Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using React.Children.only #36

Open
acontreras89 opened this issue Jun 5, 2020 · 3 comments
Open

Stop using React.Children.only #36

acontreras89 opened this issue Jun 5, 2020 · 3 comments

Comments

@acontreras89
Copy link
Contributor

Why is ScrollSync using React.Children.only in its render method? It is a bit inconvenient and I cannot see a reason for it, although I may be missing something..
@okonet
Copy link
Owner

okonet commented Jun 5, 2020

I’m not sure anymore and the whole thing is better be using the new context api and hooks perhaps so feel free to submit a PR

@acontreras89
Copy link
Contributor Author

I think I can do that this week if I find myself with some time to spare at work 🙃

@Ethan-Arrowood
Copy link

https://stackoverflow.com/questions/48837831/why-react-children-only

@pcattori pcattori mentioned this issue Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@okonet @acontreras89 @Ethan-Arrowood