Unhelpful failure message when you are missing full item cost for monster killing

[DayV-git]

🐛 Bug Report

When you want to kill something, have some of the item cost bt not the full quantity, there is no message for failure reason. Example for Venenatis:

Issue: in following code, nothing is added to messages if user.bank.has(consumablesCost.itemCost) (has every item and every quantity) is false but user.owns(group.itemCost) (has required item but not quantity) is true

oldschoolbot/src/mahoji/mahojiSettings.ts

Lines 323 to 344 in 1e3182e

	if (consumablesCost.itemCost && !user.bank.has(consumablesCost.itemCost)) {
	const items = Array.isArray(monster.itemCost) ? monster.itemCost : [monster.itemCost];
	const messages: string[] = [];
	for (const group of items) {
	if (group.optional) continue;
	if (user.owns(group.itemCost)) {
	continue;
	}
	if (group.alternativeConsumables?.some(alt => user.owns(alt.itemCost))) {
	continue;
	}
	messages.push(
	`This monster requires: ${group.itemCost.items().map(i => i[0].name)}${
	group.alternativeConsumables
	? `, OR ${group.alternativeConsumables?.map(alt => alt.itemCost.items().map(i => i[0].name)).join(', ')}`
	: '.'
	}`
	);
	}
	return [false, `You don't have the items needed to kill this monster. ${messages.join(' ')}`];
	}
	}