BSO - added range cape check to reduce arrow & dart cost

[lordzuku]

Description:

added master range cape effect to work on zuk

Changes:

passed a boolean for if a master range cape is worn to the cost object, checked if true & then modified the cost per hour for darts & arrows

Other checks:

• [Y ] I have tested all my changes thoroughly.
  fixes
  Ranged Master Cape at Inferno #3827
  Emerged inferno and range master cape  #3618

[6enny6]

should this be added to src/lib/data/similaritems.ts ?

make ranger master act as an assembler

[lordzuku]

should this be added to src/lib/data/similaritems.ts ?

make ranger master act as an assembler

iirc the range max cape shouldnt act as an assembler, otherwise the ammo saving bonuses might stack, would probably need it coded into future commands as a separate ammo saving systems
a solution could be to create a user.ammoSaving object or something, & have the object return the highest ammo saving equipped

[anthonyburrow]

would probably need it coded into future commands as a separate ammo saving systems

I believe this already exists in the "specialRemoveItems" function which is called in inferno.ts, however it only accounts for the Assembler:

oldschoolbot/src/extendables/User/Bank.ts

Line 142 in 10a1503

public async specialRemoveItems(this: User, _bank: Bank) {

I would probably recommend making this function more generalized for BSO additions by adding the Ranged Master Cape percentage in this cost function instead of making a new condition for just the inferno.

[lordzuku]

would probably need it coded into future commands as a separate ammo saving systems

I believe this already exists in the "specialRemoveItems" function which is called in inferno.ts, however it only accounts for the Assembler:

oldschoolbot/src/extendables/User/Bank.ts

Line 142 in 10a1503

public async specialRemoveItems(this: User, _bank: Bank) {

I would probably recommend making this function more generalized for BSO additions by adding the Ranged Master Cape percentage in this cost function instead of making a new condition for just the inferno.

unless im mistaken (which i might be, just recently started looking over the project)
that would only apply for regular m k trips & would still need a manual patch for fixing the inferno due to the check that the ammo must be equipped, i assume that check is to fix some kind of issues

currently there is an already built system for m k trips for range max cape saving