Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Get in getter function names #180

Open
gabor-boros opened this issue May 9, 2024 · 1 comment
Open

Remove Get in getter function names #180

gabor-boros opened this issue May 9, 2024 · 1 comment
Labels
go Pull requests that update Go code good first issue Good for newcomers pedantic
Milestone
v0.1.0 - MVP

Comments

@gabor-boros
Copy link
Contributor

Summary

Having Get and Set in function/method names are far from idiomatic. Not causing any issues, but not nice (like GetReadSession or GetWriteSession).

The code should be refactored in a way to have Get only in resource-related function/method names, like GetAll or GetAllBelongsTo, but not other methods.

Example Use-cases

As someone who maintains the code, I want to have a pleasant feeling looking at it.

Drawbacks

NA
@gabor-boros gabor-boros added good first issue Good for newcomers go Pull requests that update Go code pedantic labels May 9, 2024
@gabor-boros gabor-boros added this to the v0.1.0 - MVP milestone May 9, 2024
@gabor-boros
Copy link
Contributor Author

Hey @rohit-satya,
Are you interested in picking up this as well? ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go Pull requests that update Go code good first issue Good for newcomers pedantic
Projects
None yet
Milestone
v0.1.0 - MVP
Development

No branches or pull requests
1 participant
@gabor-boros