Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldn't the devops_tests that do not execute any code be implemented as pre-commit hooks (e.g, markdown badges checks)? #25

Open
slayoo opened this issue Nov 25, 2023 · 5 comments
Open

shouldn't the devops_tests that do not execute any code be implemented as pre-commit hooks (e.g, markdown badges checks)? #25

slayoo opened this issue Nov 25, 2023 · 5 comments

Comments

@slayoo
Copy link
Member

slayoo commented Nov 25, 2023

@abulenok @Delcior ?
@slayoo slayoo mentioned this issue Nov 25, 2023
Closed
@abulenok
Copy link
Collaborator

I don't think these should become pre-commit hooks. Executing notebooks each time one wants to make a commit is redundant IMHO

@slayoo
Copy link
Member Author

slayoo commented Jan 11, 2024

thanks @abulenok !
clearly, I meant only the checks that validate markdown (e.g., presence and urls of badges)
Renaming...

@slayoo slayoo changed the title shouldn't all these devops_dests be implemented as pre-commit hooks? shouldn't the devops_tests that do not execute any code be implemented as pre-commit hooks (e.g, markdown badges checks)? Jan 11, 2024
@github-actions GitHub Actions
Copy link

Stale issue message

@slayoo slayoo reopened this Mar 26, 2024
@github-actions GitHub Actions
Copy link

Stale issue message

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Stale issue message

@slayoo slayoo reopened this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slayoo @abulenok