Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first action before reading first observation ? #10

Open
vincentberenz opened this issue Oct 26, 2019 · 5 comments
Open

first action before reading first observation ? #10

vincentberenz opened this issue Oct 26, 2019 · 5 comments
Assignees

Comments

@vincentberenz
Copy link
Collaborator

while (!destructor_was_called_ &&

I find it counter intuitive that the system waits for a first action before starting, as possibly the first action may depend on the robot state/observation.

My program was hanging forever and it took me a while to find that this was because I start my loop with:

robot_interfaces::TimeIndex time_index = ri_frontend_.get_current_timeindex();

which hanged forever as no first action had been sent yet.

@luator
Copy link
Member

luator commented Oct 28, 2019

I agree (I actually had the same issue once). I think the best solution would be to already provide observations immediately and only start sending actions once the first one is provided by the user.

@vincentberenz
Copy link
Collaborator Author

@luator should I go ahead and work on this ? (want to make sure nobody else is currently doing this)

@wumanu
Copy link
Member

wumanu commented Nov 13, 2019 via email

@luator
Copy link
Member

luator commented Nov 18, 2019

To have this documented here: We decided in an offline-discussion to try the following solution:

  • As soon as the backend is started, it starts adding observations to the time series.
  • The action time series stay empty in the beginning and only start "running" once the first action is sent by the user. It starts with the proper non-zero timeindex so that it is in sync with the observations in the same way as it is now.

I can take a look into the code to get an idea how much effort it will be to implement this.

@wumanu
Copy link
Member

wumanu commented Nov 19, 2019

that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants