Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pa11y Actions #27

Open
TheJaredWilcurt opened this issue Sep 1, 2017 · 5 comments
Open

Add support for Pa11y Actions #27

TheJaredWilcurt opened this issue Sep 1, 2017 · 5 comments

Comments

@TheJaredWilcurt
Copy link
Member

pa11y({
    actions: [
        'click element #tab-1',
        'wait for element #tab-1-content to be visible',
        'set field #fullname to John Doe',
        'check field #terms-and-conditions',
        'uncheck field #subscribe-to-marketing',
        'wait for fragment to be #page-2',
        'wait for path to not be /login',
        'wait for url to be https://example.com/'
    ]
});

We could add in a UI for this feature. We should draw some mockups of how this could be implemented.

Actions support was added into Pa11y in version 4.4.0. Updating to this version may break Koa11y, so we'll need to proceed carefully when exploring adding this feature.

Koa11y 3.0.0 ships with Node 5.12.0 built in. So we need to ensure that the version of Pa11y we are using does not require a version of Node newer than that, or we will need to drop support for a lot of legacy OS's.

@TheJaredWilcurt
Copy link
Member Author

This feature is requested in #9

@Johnsoct
Copy link
Collaborator

Johnsoct commented Sep 7, 2017

Working on UI mockups

@Johnsoct Johnsoct self-assigned this Sep 7, 2017
@Johnsoct
Copy link
Collaborator

Mockups will be presented at Thursday's meeting, 20170921.

@Johnsoct
Copy link
Collaborator

step four
step three

@Johnsoct
Copy link
Collaborator

Notes from 20170928

  1. Action "scripts" could be up to as many as 80 actions long.
  2. Individual actions should be duplicatable and draggable to reduce clicks and time to enter a redundant/common action, such as "wait for"
  3. Way to document your script as you go for organization + communication (to other users)
    1. [IDEA] Ways to group actions into smaller actions of a whole
      1. Method/action to group actions should be demonstrated with a GIF in the example section
      2. [IDEA] input at the end of the action input to merge up or down with above or below actions
  4. A way to add comments for further explaining what an action may do, such as "we are now within a modal".
  5. Inputs need a grabber.
  6. Grabber should not be on the same side, or a tab away, from the element used to group actions. If a user accidentally tabs too far and hits enter, they could break a group or move actions unintentionally --> poor usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants