Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] accelerators are built as DSOs by default, docs still say otherwise #12911

Open
minrk opened this issue Nov 6, 2024 · 3 comments
Open

Comments

@minrk
Copy link
Contributor

minrk commented Nov 6, 2024

Background information

What version of Open MPI are you using? (e.g., v4.1.6, v5.0.1, git branch name and hash, etc.)

v5.0.5

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

conda, but this is a docs issue, not relevant.

Please describe the system on which you are running

  • Operating system/version: mac
  • Computer hardware: m1
  • Network type: N/A

Details of the problem

It looks like CUDA components are built as DSOs by default starting with #12036 (this is our experience packaging for conda-forge, and I think a great default!). But the docs on DSO configuration and building with CUDA haven't been updated to reflect this, so give the false impression of what's required or what will be done by default.

In particular, these places all discuss --enable-mca-dso and have inaccurate statements with respect to the new defaults and should probably get an update:

@hppritcha
Copy link
Member

@jsquyres are you working on this?

@jsquyres
Copy link
Member

I have not had an opportunity to do so -- if you have a few cycles, please feel free to update the docs.

@hppritcha
Copy link
Member

okay i'll do it. i'll open a pr and ping you for review - probably not till after thanksgiving though!

@hppritcha hppritcha self-assigned this Nov 27, 2024
hppritcha added a commit to hppritcha/ompi that referenced this issue Nov 27, 2024
to reflect commit open-mpi@9580fd5

the commit was backported to v5.0.2 and later.

related to open-mpi#12911

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Dec 2, 2024
to reflect commit open-mpi@9580fd5

the commit was backported to v5.0.2 and later.

related to open-mpi#12911

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Dec 4, 2024
to reflect commit open-mpi@9580fd5

the commit was backported to v5.0.2 and later.

related to open-mpi#12911

Signed-off-by: Howard Pritchard <[email protected]>
(cherry picked from commit 75e7cc0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants