-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document ORTE -> PRRTE MCA parameter changes #11890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for typos and wording. Also confirmed none of the deprecated options would apply to 5.0.0 version series. I cannot say if this is an exhaustive listing.
I rebased this PR on current main/HEAD, and added a 2nd suggested commit. This commit can be squashed or deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would squash the commit, but otherwise looking good to me.
When replacing
I expected it to be perhaps just
|
The cmd line option looks like If you want to affect the defaults, then you have to use the MCA parameter: |
@rhc54 ah, thank you for explaining. Jeff shared a rendered version of the table with me: https://ompi--11890.org.readthedocs.build/en/11890/mca.html#label-mca-backward-compat And while most of these make sense to me to read, the rmaps_default_mapping_policy entries was hard for me to grok, as I expect it would be for users. I wonder if it would be worth an example explaining the concept of these parameters which get captured as extra colon-separated tags on top of other parameters.
Hmm, am I hearing you correctly then: This table isn't correctly informing users how to take the previous MCA parameter |
Sorry - no, it is the other way around. Updating the default via MCA param will change the one-shot behavior. My point was that the cmd line options (e.g., If you always want to treat hwt's as cpus, then you would set the MCA param so the default is set (probably in your default MCA param file, which is what I do). |
OK, thank you for clarifying |
Working on adding some examples |
Updated with examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qkoziol These are great examples!
One point, however -- all your examples show extra spaces around the =
in the assignment of shell variables. That actually causes a syntax error; the extra spaces need to be removed:
# This is an error
$ export FOO = bar
zsh: bad assignment
$ FOO = bar
zsh: command not found: FOO
# It's also an error in bash
$ export FOO = bar
bash: export: `=': not a valid identifier
$ FOO = bar
bash: FOO: command not found
# Either of these are correct
$ export FOO=bar
$ FOO=bar
Addresses Github issue open-mpi#7668 Co-authored-by: [email protected] Signed-off-by: Quincey Koziol <[email protected]>
@qkoziol please open up v5.0 PR |
Document MCA parameter changes from move from ORTE to PRRTE.
Addresses Github issue #7668