Revert "pml/cm: fix buffer usage in MCA_PML_CM_HVY_SEND_REQUEST_BSEND #11906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 77200be: Revert "pml/cm: fix buffer usage in MCA_PML_CM_HVY...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
…_ALLOC()" This reverts commit 5ba260f. The revert fixes a bug revealed by mtt ibm test suite. The send buffer, instead of the attached user buffer, was used for MPI_Bsend. This violates the MPI_Bsend semantic and makes it unsafe to reuse the send buffer after the function returns. bot:notacherrypick Signed-off-by: Wenduo Wang <[email protected]>
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 5e68381: Revert "pml/cm: fix buffer usage in MCA_PML_CM_HVY...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
wenduwan
changed the title
lrbison
approved these changes
Sep 7, 2023
awlauria
approved these changes
Sep 7, 2023
|
@wzamazon Thanks for the reminder. I'll look into the remaining failures. I just checked mtt. After merging the revert on main branch, we are down to 8 failures. The intel bsend_init_overtake is the only bsend failure - I need to look closer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5ba260f.
The revert fixes a bug revealed by mtt ibm test suite. The send buffer, instead of the attached user buffer, was used for MPI_Bsend.
This violates the MPI_Bsend semantic and makes it unsafe to reuse the send buffer after the function returns.
bot:notacherrypick
Signed-off-by: Wenduo Wang [email protected]