Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcoll/vulcan: add two_phase read_all #12894

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fcoll/vulcan: add two_phase read_all #12894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6043ac5
fcoll/vulcan: cleanup write_all operations
edgargabriel Oct 7, 2024
4b356be
fcoll/vulcan: minor code reorg
edgargabriel Oct 8, 2024
030ead1
fcoll/vulcan: add read_all implementation
edgargabriel Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ompi/mca/fcoll/vulcan/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# Copyright (c) 2012 Cisco Systems, Inc. All rights reserved.
# Copyright (c) 2018 Research Organization for Information Science
# and Technology (RIST). All rights reserved.
# Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
# $COPYRIGHT$
#
# Additional copyrights may follow
Expand All @@ -22,6 +23,7 @@

sources = \
fcoll_vulcan.h \
fcoll_vulcan_internal.h \
fcoll_vulcan_module.c \
fcoll_vulcan_component.c \
fcoll_vulcan_file_read_all.c \
Expand Down
3 changes: 1 addition & 2 deletions ompi/mca/fcoll/vulcan/fcoll_vulcan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* and Technology (RIST). All rights reserved.
* Copyright (c) 2024 Triad National Security, LLC. All rights
* reserved.
* Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand All @@ -40,8 +41,6 @@ BEGIN_C_DECLS
/* Globally exported variables */

extern int mca_fcoll_vulcan_priority;
extern int mca_fcoll_vulcan_num_groups;
extern int mca_fcoll_vulcan_write_chunksize;
extern int mca_fcoll_vulcan_async_io;
extern int mca_fcoll_vulcan_use_accelerator_buffers;

Expand Down
17 changes: 1 addition & 16 deletions ompi/mca/fcoll/vulcan/fcoll_vulcan_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* reserved.
* Copyright (c) 2024 Triad National Security, LLC. All rights
* reserved.
* Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -43,8 +44,6 @@ const char *mca_fcoll_vulcan_component_version_string =
* Global variables
*/
int mca_fcoll_vulcan_priority = 10;
int mca_fcoll_vulcan_num_groups = 1;
int mca_fcoll_vulcan_write_chunksize = -1;
int mca_fcoll_vulcan_async_io = 0;

/*
Expand Down Expand Up @@ -91,20 +90,6 @@ vulcan_register(void)
OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &mca_fcoll_vulcan_priority);

mca_fcoll_vulcan_num_groups = 1;
(void) mca_base_component_var_register(&mca_fcoll_vulcan_component.fcollm_version,
"num_groups", "Number of subgroups created by the vulcan component",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &mca_fcoll_vulcan_num_groups);

mca_fcoll_vulcan_write_chunksize = -1;
(void) mca_base_component_var_register(&mca_fcoll_vulcan_component.fcollm_version,
"write_chunksize", "Chunk size written at once. Default: stripe_size of the file system",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &mca_fcoll_vulcan_write_chunksize);

mca_fcoll_vulcan_async_io = 0;
(void) mca_base_component_var_register(&mca_fcoll_vulcan_component.fcollm_version,
"async_io", "Asynchronous I/O support options. 0: Automatic choice (default) "
Expand Down
Loading
Loading