Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] replace package.json#browsers with package.json#exports.browser #4543

Open
dyladan opened this issue Mar 13, 2024 · 1 comment · May be fixed by #5063
Open

[all] replace package.json#browsers with package.json#exports.browser #4543

dyladan opened this issue Mar 13, 2024 · 1 comment · May be fixed by #5063
Labels
needs:code-contribution This feature/bug is ready to implement never-stale triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@dyladan
Copy link
Member

dyladan commented Mar 13, 2024

We are currently using the browser property of the package.json in order to have browser overrides for node-specific functions. This field is actually not even specified by npm/node, but by webpack. As pointed out by @SimenB in #3723 (reply in thread) this causes issues with at least Jest and likely other build tools.

We should switch to use the more modern conditional exports with a browser stanza in order to ensure greater compatibility with more tools and runtimes.
@pichlermarc pichlermarc added up-for-grabs Good for taking. Extra help will be provided by maintainers triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address needs:code-contribution This feature/bug is ready to implement and removed feature-request labels Mar 18, 2024
@pichlermarc pichlermarc changed the title Replace package.json#browsers with package.json#exports.browser [all] replace package.json#browsers with package.json#exports.browser Mar 18, 2024
@pichlermarc pichlermarc mentioned this issue Mar 18, 2024
Closed
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 20, 2024
@alexwine36 alexwine36 linked a pull request Oct 10, 2024 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:code-contribution This feature/bug is ready to implement never-stale triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(opentelemetry-api): update browser field alexwine36/opentelemetry-js
3 participants
@dyladan @pichlermarc @JamieDanielson