Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge adbutils_async as an Asynchronous Version of adbutils #132

Open
touxiaoling opened this issue Jun 1, 2024 · 2 comments
Open

Merge adbutils_async as an Asynchronous Version of adbutils #132

touxiaoling opened this issue Jun 1, 2024 · 2 comments

Comments

@touxiaoling
Copy link

Hello,

I have rewritten an asynchronous version of adbutils called adbutils_async, which you can find here: https://github.com/touxiaoling/adbutils_async. I have been using it with real devices for the past two months. However, this version only supports Python 3.10+.

I would like to inquire if you would be interested in helping me merge adbutils_async into the openatx/adbutils repository.

Here are some questions:

  1. Compatibility: This version currently only supports Python 3.10+. I have only tested it with Python 3.12. However, I don't have much experience in adding compatibility for other versions. Could you provide some suggestions on this?
  2. Testing: The test cases are not comprehensive. Should I complete and improve the asynchronous test cases before you consider merging it?

Please let me know if there are any additional requirements or modifications needed. I am open to collaborating and making necessary adjustments to ensure compatibility and maintainability.

Thank you for your time and consideration.

Best regards,
touxiaoling

@codeskyblue
Copy link
Member

Wow it is amazing to hear that. Tests is required for new functions. The lib httpx can be referenced for sync and async how does it exists both in one lib.

@codeskyblue
Copy link
Member

Use miniconda can create Python 3.8 environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants