Variable bubble size #460
Open
Variable bubble size #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Probably ready for @braddf and @rachel-labri-tipton to have a look at. I was going to remove the key too, should it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adjust the bubble size depending on the total capacity of all the sites
Have not done #444, so probably best to comment this out for the moment - TODO
Fixes #445
added a few tests too
For a user with only 5 sites goes from (its the same for the ocf group)
to
How Has This Been Tested?
Ran in on vercel, tested out the OCF group and a site group that only has about 5 sites.
Checklist: