Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues cleanup #7741

Open
artificiel opened this issue Nov 1, 2023 · 1 comment
Open

issues cleanup #7741

artificiel opened this issue Nov 1, 2023 · 1 comment

Comments

@artificiel
Copy link
Contributor

artificiel commented Nov 1, 2023

I accumulate notes on issues as I stumble upon them. here is a lump of actionable ones:

Can close:

#6543 (duplicate / fixed in #6668)
#6268 (caused by user-local params)
#5512 (fixed by #5651)
#5473 (fixed by openframeworks/apothecary#69)
#5236 + #2928 (fixed by #6224)
#4951 (closed by #4979)
#3392 #7282 #4448 (fixed by clang-format)
#7145 #2424 #7022 #6183 #5372 #4560 #6760 #3159 #5429 #3053 #4482 #1714 #1650 (stale)
#4856 (answer: not against, and NB: ofBaseApp is inheritance override is good in base template)
#7291 (closed by #7301)
#6884 (closed by #7371)
#1554 (sprawling issue; PRs are in for relevant points)
#4940 (not an issue per se)
#4194 (closed by 549447a)

Just need quick checks/confirmations:

#7121 (closed by #7367 #7366 #7357) TBC by @dimitre
#6793 (closed by #6821 #6823 #6824 #6829 #6838) TBC by @dimitre
#1599 #1034 (solved by ADDON_DATA?)
#3833 resolved and/or under new thresholds?
#6900 still?
#4804 still valid?
#4519 still an issue? Need a revival/test to reveal the problem.

Move to PG (if GitHub allows that):

#2270 #1126 #1234
Can merge:

#5145 #6819

@dimitre
Copy link
Member

dimitre commented Nov 22, 2023

Great. I've tagged some issues with the tag "close" a while ago, with some I think can be closed now too:
https://github.com/openframeworks/openFrameworks/issues?q=is%3Aissue+is%3Aopen+label%3Aclose+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants