-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: QuantEcon.py: A community based Python library for quantitative economics #5585
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @jstac @janosg @mnwhite this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@sbenthall) if you have any questions/concerns. |
Review checklist for @janosgConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@janosg thank you for the issues and review. Greatly appreciated. I think I have now addressed both comments linked above. I have also opened this discussion to see if we can make improvements through a more direct example gallery. Currently examples are provided across our lecture series and in the QuantEcon.py documentation docstrings. |
Thanks @mmcky. I added a suggestion to your discussion but that is not a prerequisite for acceptance. quantecon.py is a great package and it was a pleasure to review it! @sbenthall my review is complete. |
Thank you @janosg ! |
Hello @mnwhite , this submission is still waiting for your review. |
Getting to this soon.
…On Thu, Jul 20, 2023 at 12:29 PM Sebastian Benthall < ***@***.***> wrote:
Hello @mnwhite <https://github.com/mnwhite> , this submission is still
waiting for your review.
Please let me know if you have any questions about the process.
—
Reply to this email directly, view it on GitHub
<#5585 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFMRKSEU4CHMH2AZLNTXRFMGFANCNFSM6AAAAAAZQ3VEAM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Review checklist for @mnwhiteConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@mnwhite – how are you getting on here. Do you think you might be able to complete your review in the next week or so? |
Yes, my schedule has opened up quite a bit and I can now prioritize this.
…On Sun, Oct 1, 2023, 2:51 AM Arfon Smith ***@***.***> wrote:
@mnwhite <https://github.com/mnwhite> – how are you getting on here. Do
you think you might be able to complete your review in the next week or so?
—
Reply to this email directly, view it on GitHub
<#5585 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFPMU5BOONNWAPZOADTX5EHIVANCNFSM6AAAAAAZQ3VEAM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@arfon @sbenthall Is there a target date for the first round referee process? Please let us know if we can help expedite by providing more information. |
It was probably long ago. I am the holdup. I began working on my review,
then got distracted, and now I have a newborn. I will try to get to this
ASAP, I'm really sorry, John.
…On Mon, Oct 30, 2023, 12:08 AM John Stachurski ***@***.***> wrote:
@arfon <https://github.com/arfon> @sbenthall
<https://github.com/sbenthall> Is there a target date for the first round
referee process? Please let us know if we can help expedite by providing
more information.
—
Reply to this email directly, view it on GitHub
<#5585 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFLTAZYC5JJMVP65JSTYB4R4TAVCNFSM6AAAAAAZQ3VEAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGQ2DMMRSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No problem @mnwhite, I've been in your shoes and I remember what it was like. We're looking forward to your review when you're ready to submit. |
@mnwhite Sorry to keep pinging you but it would help some of the young people listed as coauthors. Hopefully it won't take too long. |
"You're hurting young economists" is my trigger. I will get this done
tomorrow.
…On Mon, Nov 20, 2023, 11:43 PM John Stachurski ***@***.***> wrote:
@mnwhite <https://github.com/mnwhite> Sorry to keep pinging you but it
would help some of the young people listed as coauthors. Hopefully it won't
take too long.
—
Reply to this email directly, view it on GitHub
<#5585 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFIK5BMVV7SXQS63KRLYFQWN5AVCNFSM6AAAAAAZQ3VEAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGIZTCOBUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@jstac @sbenthall I finally, finally, finally got around to this. I am so sorry this took so long and kept slipping. John: Are you in Canberra? If so, cookies (etc) will be sent to your office. |
thanks @sbenthall and @danielskatz. I appreciate the clarifications and guidance. |
thanks again @danielskatz and @sbenthall. I have now setup a Zenodo record of the @sbenthall please let me know if you need anything further. Many thanks. |
@sbenthall can you please let me know if there is anything else required? Many thanks. |
@editorialbot set 10.5281/zenodo.10345102 as archive |
Done! archive is now 10.5281/zenodo.10345102 |
@editorialbot set 0.7.1 as version |
Done! version is now 0.7.1 |
@editorialbot recommend-accept |
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4853, then you can now move forward with accepting the submission by compiling again with the command |
|
Hi @sbenthall , happy new year and thanks again for your help in shepharding this paper through! Just quickly: one of the junior coauthors is applying for a scholarship and it would be very helpful if this was published on the main site. Is there a timeline? (I'm writing a recommendation letter for him so if you can let me know I'll adjust it accordingly.) Thanks in advance. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4874, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
You can definitely use the DOI to refer to this now, if needed, see above. Apologies for slow reply; Xmas, new year, etc. Good luck with the application. |
Huge thanks to the reviewers @janosg, @mnwhite and editor @sbenthall! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the authors! 🥳 🍾 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jstac (John Stachurski)
Repository: https://github.com/QuantEcon/QuantEcon.py
Branch with paper.md (empty if default branch): joss_paper
Version: 0.7.1
Editor: @sbenthall
Reviewers: @janosg, @mnwhite
Archive: 10.5281/zenodo.10345102
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@janosg & @mnwhite, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sbenthall know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @janosg
📝 Checklist for @mnwhite
The text was updated successfully, but these errors were encountered: