-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: pySLM2: A full-stack python package for holographic beam shaping #6205
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Checking the BibTeX entries failed with the following error:
|
|
Failed to discover a |
|
Hello @ldes89150, thanks for your submission to JOSS. We'll use this pre-review issue to assign an editor and find reviewers; unfortunately, we don't have any editors available to handle your submission right now, so I need to put this on our waitlist until someone can edit it. In the meantime, any reviewer recommendations you can make would be welcome. |
@ldes89150 it looks like the JOSS paper is located on the |
Hi @kyleniemeyer , Yes, it is in the |
@editorialbot set paper.md as branch |
Done! branch is now paper.md |
@editorialbot generate pdf |
@ldes89150 we just needed to specify the branch, since our editorialbot looks for the paper in the main branch by default. I'm not quite sure what is causing the error in building the PDF, though. |
@openjournals/dev @arfon do you understand this error in the PDF build job?
|
Probably the error comes from the branch being named |
@editorialbot set paper as branch |
Done! branch is now paper |
@editorialbot generate pdf |
Five most similar historical JOSS papers: PySDM v1: particle-based cloud modeling package for warm-rain microphysics and aqueous chemistry SkyPy: A package for modelling the Universe prysm: A Python optics module s(ound)lab: An easy to learn Python package for designing and running psychoacoustic experiments. beamshapes: a Python package to generate directivity patterns for various sound source models |
@kyleniemeyer changing the paper.md branch name to paper made the pdf work |
@editorialbot generate my checklist |
Checklists can only be created once the review has started in the review issue |
@editorialbot add @sidihamady as reviewer
Excellent, thank you for the prompt response, testing only the software component will be fine. |
@sidihamady added to the reviewers list! |
@ldes89150, since we haven't found any reviewers for testing the hardware integration, would you be willing to add Any suggestions for other reviewers for the hardware section would also be very welcome. |
@editorialbot generate my checklist |
Checklists can only be created once the review has started in the review issue |
Sorry @sidihamady, I need to wait for @ldes89150 to confirm the The checklist can be generated after that, in the |
@editorialbot commands |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot commands |
Hello @ldes89150, here are the things you can ask me to do:
|
@editorialbot generate my checklist |
Checklists can only be created once the review has started in the review issue |
@HaoZeke What exactly do I need to do? |
I added it to the paper. Let me know if there is still something I need to do. Thanks! |
@editorialbot generate pdf |
1 similar comment
Five most similar historical JOSS papers: SkyPy: A package for modelling the Universe PySDM v1: particle-based cloud modeling package for warm-rain microphysics and aqueous chemistry beamshapes: a Python package to generate directivity patterns for various sound source models prysm: A Python optics module PiSCAT: A Python Package for Interferometric Scattering Microscopy |
1 similar comment
Five most similar historical JOSS papers: SkyPy: A package for modelling the Universe PySDM v1: particle-based cloud modeling package for warm-rain microphysics and aqueous chemistry beamshapes: a Python package to generate directivity patterns for various sound source models prysm: A Python optics module PiSCAT: A Python Package for Interferometric Scattering Microscopy |
I could review this paper but the situation is the same as the other reviewers; I don't have the hardware. |
@editorialbot add @ktahar as reviewer
That's alright, thanks for accepting the request to review. |
@ktahar added to the reviewers list! |
@editorialbot start review @ldes89150 thanks for the quick turn-around. We can now proceed with the review. |
OK, I've started the review over in #6315. |
Submitting author: @ldes89150 (Chung-You Shih)
Repository: https://github.com/QITI/pySLM2
Branch with paper.md (empty if default branch): paper
Version: v0.1.0
Editor: @HaoZeke
Reviewers: @brandondube, @sidihamady, @ktahar
Managing EiC: Kyle Niemeyer
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @ldes89150. Currently, there isn't a JOSS editor assigned to your paper.
@ldes89150 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: