Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random test failures in t/stream/os-getenv-hup.t #316

Open
agentzh opened this issue Oct 8, 2020 · 1 comment
Open

Random test failures in t/stream/os-getenv-hup.t #316

agentzh opened this issue Oct 8, 2020 · 1 comment
Assignees

Comments

@agentzh
Copy link
Member

agentzh commented Oct 8, 2020

I'm seeing the following random test failures on Fedora x86_64:

t/stream/os-getenv-hup.t ........... 1/13
#   Failed test 'TEST 2: HUP reload changes env value (1/3) - response_body - response is expected (repeated req 0, req 0)'
#   at /home/agentzh/git/lua-resty-core.orig/../test-nginx/lib/Test/Nginx/Socket.pm line 1594.
#          got: "old\x{0a}"
#       length: 4
#     expected: "new\x{0a}"
#       length: 4
#     strings begin to differ at char 1 (line 1 column 1)
t/stream/os-getenv-hup.t ........... 10/13
#   Failed test 'TEST 5: HUP reload changes visible environment variable (1/2) - response_body - response is expected (repeated req 0, req 0)'
#   at /home/agentzh/git/lua-resty-core.orig/../test-nginx/lib/Test/Nginx/Socket.pm line 1594.
#          got: "nil\x{0a}"
#       length: 4
#     expected: "old\x{0a}"
#       length: 4
#     strings begin to differ at char 1 (line 1 column 1)

#   Failed test 'TEST 6: HUP reload changes visible environment variable (2/2) - response_body - response is expected (repeated req 0, req 0)'
#   at /home/agentzh/git/lua-resty-core.orig/../test-nginx/lib/Test/Nginx/Socket.pm line 1594.
#          got: "old\x{0a}"
#       length: 4
#     expected: "new\x{0a}"
#       length: 4
#     strings begin to differ at char 1 (line 1 column 1)
# Looks like you failed 3 tests of 13.
t/stream/os-getenv-hup.t ........... Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/13 subtests
@agentzh
Copy link
Member Author

agentzh commented Oct 8, 2020

The random failures can be reproduced by setting the env TEST_NGINX_SLEEP=0.001. The tests should be made more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants