Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Index patterns via role #68

Closed
wants to merge 7 commits into from

Conversation

ssi444
Copy link
Contributor

@ssi444 ssi444 commented May 24, 2022

Description

Added the ability to automatically create index patterns.

Issues Resolved

#66

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ssi444 added 7 commits May 12, 2022 14:07
…and set them /bin/false shell

Signed-off-by: Sergey Shubin <[email protected]>
1. Added the ability to log in via OpenID
2. Added the ability to install custom configuration files for the cluster
3. Added the ability to reconfigure the cluster (in particular, update certificates) when expanding it
4. Added the ability not to change certificates if the cluster composition has not changed, but only the settings have changed.

Signed-off-by: Sergey Shubin <[email protected]>
…cies" section have been added to the readme.

Signed-off-by: Sergey Shubin <[email protected]>
…patterns" section have been added to the readme.

Signed-off-by: Sergey Shubin <[email protected]>
@ssi444 ssi444 requested a review from a team as a code owner May 24, 2022 13:54
@ssi444
Copy link
Contributor Author

ssi444 commented May 24, 2022

Calling @saravanan30erd @prudhvigodithi for the review.
Thanks.

@ssi444
Copy link
Contributor Author

ssi444 commented May 31, 2022

@peterzhuamazon
Copy link
Member

@saravanan30erd Please let me know if you have bandwidth to review this.
@ssi444 Sorry we are focusing on two minor releases in the past weeks that is why this is pretty slow.
Thanks.

@ssi444
Copy link
Contributor Author

ssi444 commented Jun 21, 2022

1 similar comment
@ssi444
Copy link
Contributor Author

ssi444 commented Jun 27, 2022

then only in this case the task of setting passwords for internal users from variables is started. If the file `internal_users.yml`
is not located in the `files` directory, but, for example, in one of its subdirectories, then playbook will not work correctly

### IaC (Infrastructure-as-Code)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkPassword: none
file: root-ca.pem

### Default values and global settings
defaults:
validityDays: 730
validityDays: {{ cert_valid_days }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as this existing PR @ssi444
https://github.com/opensearch-project/ansible-playbook/pull/63/files
Should we revisit this until the other is merged ?
@saravanan30erd @peterzhuamazon

Copy link
Contributor Author

@ssi444 ssi444 Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is divided into logical blocks at @saravanan30erd request, so there are 3 PR's. @prudhvigodithi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest merging the code in the order of creating PR

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jun 28, 2022

Hey @ssi444 can you please elaborate this functionality, we expect users to add multiple indexes under a pattern, in this scenario how does this functionality helps? Also with this can we load an index to created pattern?

@ssi444
Copy link
Contributor Author

ssi444 commented Jun 29, 2022

Hey @ssi444 can you please elaborate this functionality, we expect users to add multiple indexes under a pattern, in this scenario how does this functionality helps? Also with this can we load an index to created pattern?

@prudhvigodithi
After sending logs is configured, indexes for incoming data are created in OpenSearch. But it is impossible to search these indexes until an IndexPattern is created. This change allows you to create the necessary IndexPattern in different Tenants based on the configuration file, and not manually. This allows this role to take another step to manage the OpenSearch cluster using the IaC methodology

@prudhvigodithi
Copy link
Member

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

@ssi444
Copy link
Contributor Author

ssi444 commented Mar 23, 2023

Hey @ssi444 apologies for the delay, do you think we still need this change to move forward?

yes, I think this is the necessary functionality

@bbarani
Copy link
Member

bbarani commented Sep 25, 2023

@prudhvigodithi @saravanan30erd @peterzhuamazon Anyone looking in to this PR?

@dblock
Copy link
Member

dblock commented Jul 1, 2024

Looks like a good feature, however the PR got stalled and wasn't merged, sorry about that. Closing it for now, if you feel it does need to be merged, please rebase, and I can try to assign it to a maintainer in this repo.

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

@dblock dblock closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants