Fix setup-test-cluster node selector #147
Conversation
|
/ok-to-test |
openshift-ci-robot
added
the
ok-to-test
|
good catch! |
|
@e-minguez: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hmm, actually, isn't the !master enough? |
I guess this is to prevent CNF features running on 'infra' nodes https://docs.openshift.com/container-platform/4.3/machine_management/creating-infrastructure-machinesets.html ( |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: e-minguez, fedepaol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/retest |
|
@e-minguez: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@e-minguez: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @e-minguez you close this one? can I reopen it? |
Sure. I was cleaning old unmerged PRs, but if you think this would be helpful... |
Fixes #146