Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify & Remedy Duplicate Sponsors #347

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

NewAgeAirbender
Copy link
Contributor

Creates a page where people can submit match requests between multiple sponsor options for the matcher. Users can submit as many duplicates as they think are right, immediately goes to a pr with an appended name and id for that person.

Example: someone added a middle initial to a name, so there exists both a "Richard P. Creagan" and "Richard Creagan" (HI), or 2 "Sonya Jaquez Lewis"s (CO) with different OS ids.

@jamesturk

Copy link
Member

@jamesturk jamesturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems really useful, but we'll need to figure out a few things on the backend before we can merge:

  • having two users with the same ID present in their additional IDs causes issues when we attempt to look up by ID, so we need to avoid that
  • the right thing to do here is to delete the less-used ID and alias it to the more used ID
  • that'd require us adding code for deletion, which isn't present yet

maybe next week we can sync on this a bit more to discuss options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants