Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Soft fail when tracer cannot load to prevent taking down Kubernetes ingress-nginx #172

Open
pzimno opened this issue Jun 28, 2021 · 2 comments

Comments

@pzimno
Copy link

pzimno commented Jun 28, 2021

Related ingress-nginx issue

Currently raising NGX_ERROR seems to result in ingress-nginx going down. This could possibly be resolved by config validation in the ingress-nginx project or a different mechanism for handling errors in nginx-opentracing.

@kjivan
Copy link

kjivan commented Oct 31, 2024

Just wanted to mention we hit this yesterday and it was surprising to realize essentially our cluster broke because Jaeger went down.

@sriemer
Copy link
Contributor

sriemer commented Nov 7, 2024

At IBM Observability by Instana APM we handle this with a K8s autotrace mutating webhook admission controller. It automatically does the required transformations of ConfigMap and deployment. Further components provide the required tracer binaries and symlinks to them fully automatically all together so that this case cannot happen.

We have the right timing and delay the startup of the NGINX of Ingress NGINX until the tracer is configured properly.
This solves a chicken-and-egg problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants