Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using GRPC mode, how to update the sampling strategy synchronously from the remote end(Jaeger-collector) #177

Open
huangjiecheng opened this issue Jul 14, 2021 · 3 comments

Comments

@huangjiecheng
Copy link

No description provided.

@huangjiecheng
Copy link
Author

When I modify the sampling strategy configuration file, the log also shows that it has been updated. However, the log call chain collected by nginx-opentracing still implements the original sampling strategy.

@miry
Copy link
Collaborator

miry commented Jul 20, 2021

@huangjiecheng Can you make title a bit shorter and move all details in description?
I think the options provided through config file and nginx-opentracing could not controll sampling.

@huangjiecheng
Copy link
Author

huangjiecheng commented Jul 21, 2021

@miry

Describe the bug

When I used the remote sampling strategy, I modified the sampling strategy configuration file of jaeger-collector, and the call chain collected by jaeger-client-cpp still used the original sampling strategy without refreshing.

To Reproduce

Steps to reproduce the behavior:

1.Deploy jaeger-agent on the same machine as jaeger-client-cpp and use the default remote sampling strategy.

2.Deploy the jaeger-collector on the other host and specify the sampling strategy configuration file.Flags: --sampling.strategies-file --sampling.strategies-reload-interval

3.Modify the sampling strategy configured for the jaeger-collector.

4.The sampling strategy used in the sampling result is still the original configuration file.

Expected behavior

The used sampling strategy must be the same as the latest configured sampling strategy .

Screenshots

image

Version (please complete the following information):

OS: Linux
Jaeger version: 1.23.0
Deployment:bare metal
Nginx version: openresty/1.17.8.2
What troubleshooting steps did you try?
-Tracer config file: {"service_name":"***","disabled":false,"sampler":{"samplingRefreshInterval":1,"param":"1","type":"remote"},"reporter":{"localAgentHostPort": "127.0.0.1:6831","logSpans":true},"propagation_format":"w3c"}
-Jaeger-agent: ./jaeger_agent --reporter.grpc.host-port=jaeger-collector.host:14250

Additional context

Add any other context about the problem here.

@huangjiecheng huangjiecheng changed the title My jaeger version is 1.23, and the jaeger-collector component has enabled --sampling.strategies-reload-interval, but the collected logs show that the sampling strategy is still old When using GRPC mode, how to update the sampling strategy synchronously from the remote end(Jaeger-collector) Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants