Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does opentracing_trust_incoming_span erase baggage? #236

Open
james-callahan opened this issue Nov 26, 2021 · 2 comments
Open

Does opentracing_trust_incoming_span erase baggage? #236

james-callahan opened this issue Nov 26, 2021 · 2 comments

Comments

@james-callahan
Copy link

When setting opentracing_trust_incoming_span=false, does baggage get erased?
I couldn't see any code to do so (but I haven't tested).

Otherwise the potential issue is that an upstream will think that baggage is being added by nginx itself.

@miry
Copy link
Collaborator

miry commented Nov 29, 2021

@james-callahan Do you have an example how we can reproduce the problem?

@james-callahan
Copy link
Author

Do you have an example how we can reproduce the problem?

I would verify it by:

  • Setting up an nginx configured to use jaeger, set opentracing_trust_incoming_span=false
  • Send a request to nginx with a baggage header set, e.g. uberctx-foo: bar
  • Check if that header made it through to the upstream service. It shouldn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants