[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Round operation

[a-sidorova]

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

• Create fp32 Round operation JIT emitter for ARM64 SIMD platform. Use OpenVINO CPU plugin JIT emitters documentation and Arm A-profile A64 Instruction Set Architecture documentation for details. Notice that the op Round has two modes of rounding: half_to_even and half_away_from_zero. The JIT emitter should support the both modes.
• Modify ARM64 executor and ARM64 kernel (in both places: create_eltwise_emitter and get_supported_precisions) to apply developed JIT emitter.

Before emitter implementation, please, modify tests to be sure that developed functionality is covered by test:

• Add jit kernel check in activation test, the test must fail.
• If test doesn't fail then add supported activation type (RoundHalfToEven and RoundHalfAwayFromZero) in CPU activation test instantiation if it's absent.
• For the better test coverage, update input generation algorithm to generate values with floating point.

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use GoogleTest filter:

./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Activation*Round*"

Example Pull Requests

• Abs operation: [CPU] [ARM64] jit abs #23692
• Sigmoid operation, which reuses Exp emitter: [CPU] [ARM64] jit sigmoid #23065

Resources

• Contribution guide - start here!
• What is OpenVINO?
• CPU plugin JIT emitters
• Blog post on contributing to OpenVINO
• User documentation
• Intel DevHub Discord channel - engage in discussions, ask questions and talk to OpenVINO developers
• How to link your Pull Request to an issue

Contact points

@a-sidorova, @dmitry-gorokhov

[emir05051]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[emir05051]

May I get some help please ? I get this error, when I'm trying to push. Also should Round be implemented as one operator for two modes or two operators for two modes like in src/nodes/eltwise.cpp?

Run # Needed as the Linux CC does not require setupvars to work
[setupvars.sh] OpenVINO environment initialized
ERROR:conformance_utilities:/__w/openvino does not contain applicable directories to pattern: bin
WARNING:test_parallel_runner:Please set the above env variable to get the same conformance ir names run by run!
INFO:test_parallel_runner:[ARGUMENTS] --exec_file=/__w/openvino/openvino/install/tests/ov_cpu_func_tests
INFO:test_parallel_runner:[ARGUMENTS] --working_dir=/__w/openvino/openvino/install/tests
INFO:test_parallel_runner:[ARGUMENTS] --process_timeout=3600
INFO:test_parallel_runner:[ARGUMENTS] --cache_path=/__w/openvino/openvino/install/tests/test_cache.lst
INFO:test_parallel_runner:[ARGUMENTS] --workers=8
INFO:test_parallel_runner:[ARGUMENTS] --parallel_devices=0
INFO:test_parallel_runner:[ARGUMENTS] --split_unit=suite
INFO:test_parallel_runner:[ARGUMENTS] --repeat_failed=0
INFO:test_parallel_runner:[ARGUMENTS] --excluded_tests_file=None
INFO:test_parallel_runner:[ARGUMENTS] Executable file arguments = ['--gtest_print_time=1', '--gtest_filter=*smoke*']
INFO:test_parallel_runner:Run test parallel is started. Worker num is 8
INFO:test_parallel_runner:Get test list using command: /__w/openvino/openvino/install/tests/ov_cpu_func_tests --gtest_print_time=1 --gtest_filter=*smoke* --gtest_list_tests > /__w/openvino/openvino/install/tests/test_list.lst
INFO:test_parallel_runner:Len test_list_runtime (without disabled tests): 1555
INFO:test_parallel_runner:Get test list from cache file: /__w/openvino/openvino/install/tests/test_cache.lst
INFO:test_parallel_runner:Len tests_dict_cache: 1555
INFO:test_parallel_runner:Total test counter is [17](https://github.com/openvinotoolkit/openvino/actions/runs/12147153611/job/33874519329?pr=27885#step:13:18)6458
INFO:test_parallel_runner:Execute jobs taken from cache and runtime
Worker initialization: [........................................] 0/8
Worker initialization: [#####...................................] 1/8
Worker initialization: [##########..............................] 2/8
Worker initialization: [###############.........................] 3/8
Worker initialization: [####################....................] 4/8
Worker initialization: [#########################...............] 5/8
Worker initialization: [##############################..........] 6/8
Worker initialization: [###################################.....] 7/8
Worker initialization: [########################################] 8/8
Worker execution: [........................................] 0/16
Worker execution: [##......................................] 1/16
Worker execution: [#####...................................] 2/16
Worker execution: [#######.................................] 3/16
Worker execution: [##########..............................] 4/16
Worker execution: [############............................] 5/16
Worker execution: [###############.........................] 6/16
Worker execution: [#################.......................] 7/16
Worker execution: [####################....................] 8/16
Worker execution: [######################..................] 9/16
Worker execution: [#########################...............] 10/16
Worker execution: [###########################.............] 11/16
Worker execution: [##############################..........] 12/16
Worker execution: [################################........] 13/16
Worker execution: [###################################.....] 14/16
Worker execution: [#####################################...] 15/16
Worker execution: [########################################] 16/16
INFO:test_parallel_runner:Compeleting processes: Active process counter: 7...
INFO:test_parallel_runner:Compeleting processes: Active process counter: 6...
INFO:test_parallel_runner:Compeleting processes: Active process counter: 5...
INFO:test_parallel_runner:Compeleting processes: Active process counter: 4...
INFO:test_parallel_runner:Compeleting processes: Active process counter: 3...
INFO:test_parallel_runner:Compeleting processes: Active process counter: 2...
INFO:test_parallel_runner:Compeleting processes: Active process counter: 1...
INFO:test_parallel_runner:Compeleting processes: Active process counter: 0...
INFO:test_parallel_runner:Get test list using command: /__w/openvino/openvino/install/tests/ov_cpu_func_tests --gtest_print_time=1 --gtest_filter=*smoke* --gtest_list_tests > /__w/openvino/openvino/install/tests/test_list.lst
INFO:test_parallel_runner:Len test_list_runtime (without disabled tests): 175871
INFO:test_parallel_runner:Run test parallel is finished successfully. Total time is 0h:[20](https://github.com/openvinotoolkit/openvino/actions/runs/12147153611/job/33874519329?pr=27885#step:13:21)m:10.02s
INFO:test_parallel_runner:Log analize is started
INFO:test_parallel_runner:Hashed test list is saved to: /__w/openvino/openvino/install/tests/logs/hash_table.csv
INFO:test_parallel_runner:Fix priorities list is saved to: /__w/openvino/openvino/install/tests/logs/fix_priority.csv
INFO:test_parallel_runner:Disabled test list is saved to: /__w/openvino/openvino/install/tests/logs/disabled_tests.log
INFO:test_parallel_runner:Get test list using command: /__w/openvino/openvino/install/tests/ov_cpu_func_tests --gtest_print_time=1 --gtest_filter=*smoke* --gtest_list_tests > /__w/openvino/openvino/install/tests/test_list.lst
INFO:test_parallel_runner:Len test_list_runtime (without disabled tests): 175871
INFO:test_parallel_runner:passed test counter is: 154111
INFO:test_parallel_runner:skipped test counter is: [21](https://github.com/openvinotoolkit/openvino/actions/runs/12147153611/job/33874519329?pr=27885#step:13:22)754
INFO:test_parallel_runner:failed test counter is: 6
INFO:test_parallel_runner:disabled test counter is: 20
INFO:test_parallel_runner:Total test count with disabled tests is 175891. All logs is saved to /__w/openvino/openvino/install/tests/logs
ERROR:test_parallel_runner:Run is not successful

[dmitry-gorokhov]

@emir05051 Thanks for the contribution!
It is ok to have to seprate emitters.
As of CI issue: anwered in the PR.