-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: separate clients for yurt-manager #2069
Conversation
19dd93a
to
947e50d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2069 +/- ##
==========================================
- Coverage 56.09% 56.09% -0.01%
==========================================
Files 186 186
Lines 18092 18090 -2
==========================================
- Hits 10149 10147 -2
Misses 6910 6910
Partials 1033 1033
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7b88938
to
6450a4b
Compare
c5a7b39
to
b01a04e
Compare
@rambohe-ch I have found the root cause of the blocking e2e tests are there are no permission for controller-manager's cache building process. As we know, Therefore, in our case we can still separate the permissions for each individual client, but the base client used by yurt-manager need the full permission at the initialization stage. |
We can create a cache for each client used by individual controllers. However, I opt against this approach due to the escalating memory footprint. |
pkg/yurtmanager/webhook/deploymentrender/v1alpha1/deploymentrender_handler.go
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
/lgtm |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Fix #2051
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note