Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of video title and description is not working on PWA reader #188

Open
benoit74 opened this issue Apr 18, 2024 · 1 comment
Open
Milestone

Comments

@benoit74
Copy link
Collaborator

Scraper version: 3.0.0 ("release candidate")

ZIM File: https://mirror.download.kiwix.org/zim/.hidden/dev/ted_mul_pain_2024-04.zim

Library: https://dev.library.kiwix.org/viewer#ted_mul_pain_2024-04

PWA version: 3.1.8

How to reproduce:

  • select any language on the main page filter combobox
  • video titles are properly updated
  • click on any video thumbnail to open the video page
  • on the video page title and description stays in English while they should quickly be translated to selected language

On kiwix-serve, you can directly navigate to such a translate page, e.g. https://dev.library.kiwix.org/content/ted_mul_pain_2024-04/how-to-deal-with-rejection?lang=fr

@Jaifroid I'm not sure this is something to fix on scraper side or on PWA side, could you please advise?

The scraper is injecting JS code which detects dynamically the URL param which is passed (e.g. fr in https://dev.library.kiwix.org/content/ted_mul_pain_2024-04/how-to-deal-with-rejection?lang=fr). Code is based on JQuery, and I find pretty hackish tbh: https://github.com/openzim/ted/blob/main/src/ted2zim/templates/assets/article.js. I hope we will be able to fully rewrite this sooner than latter (but it is probably going to be latter).

@benoit74 benoit74 added the bug label Apr 18, 2024
@benoit74 benoit74 added this to the 3.1.0 milestone Apr 18, 2024
@kelson42 kelson42 added the i18n label Jun 28, 2024
@benoit74
Copy link
Collaborator Author

This will be solved with a proper implementation of #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants