Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve favicon #146

Open
kelson42 opened this issue Jan 25, 2023 · 1 comment
Open

Improve favicon #146

kelson42 opened this issue Jan 25, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@kelson42
Copy link
Contributor

We have only a minimal support of favicon. Different devices need different favicons, check with https://realfavicongenerator.net/favicon_checker?protocol=https&site=library.kiwix.org%2Fcontent%2Fwikihow_fr_maxi%2FAccueil

@kelson42 kelson42 added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Jan 25, 2023
@rgaudin
Copy link
Member

rgaudin commented Jan 26, 2023

This probably deserves a Wiki page on overview with the decisions to make and implementation. I believe that most websites we scrape (as does wikiHow) don't respect those rules completely.

While all those options exists to provide flexibility to designers, to adapt icons to context, as we are just scraping, we won't do any creative work and are thus left with two options:

  • copy when it exists
  • resize/scale another one to the required size.

Now that's fairly easy (although arbitrary – using cubic downsizing) for generating icons that are smaller than the source we have but what about upscaling? Should we upscale icons so that all those checks are marked green or should we only provide the ones we can with same quality as what we got from upstream?

Beside this, it's important to note that choosing an icon is difficult. A lot of website have a favicon, maybe with various small sizes and a logo on their website that is different but available in a much higher resolution. As we don't have access to sources, we have to mangle with those both for the favicon(s) and the ZIM illustration(s)

@kelson42 kelson42 added this to the 1.3.0 milestone Apr 24, 2023
@benoit74 benoit74 modified the milestones: 1.2.3, 1.3.0 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants