Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Handle FirmaTypes as an Enum instead of string #47

Open
AnderssonPeter opened this issue May 15, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@AnderssonPeter
Copy link

Description
This would be a breaking change, but it would be a better DX if FirmaTypes was of type Enum instead of string.

@AnderssonPeter AnderssonPeter added the enhancement New feature or request label May 15, 2024
@Johannestegner
Copy link
Member

I kind of agree that it would be nice. But as of right now, the other packages makes use of strings, and changing the C# version to use enum would break the "same api in all languages" principle.

I will take it up with the other maintainers and see how they feel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants