You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would suggest changing the way that missing peers are reported.
Below is an example of the terminal output when I add a dependency.
Note that the missing peers are mixed in with the other log messages higher up such that they are not obvious.
In an IDE (VSCode/WebStorm), usually you only see 10 or so lines in the terminal as it is used as a bottom panel.
pnpm add expo-av
../../../../.. | Progress: resolved 1, reused 0, downloaded 0, added 0
../../../../.. | Progress: resolved 17, reused 16, downloaded 0, added 0
../../../../.. | Progress: resolved 18, reused 16, downloaded 0, added 0
../../../../.. | Progress: resolved 222, reused 207, downloaded 0, added 0
../../../../.. | Progress: resolved 223, reused 207, downloaded 0, added 0
../../../../.. | Progress: resolved 432, reused 310, downloaded 0, added 0
../../../../.. | Progress: resolved 433, reused 310, downloaded 0, added 0
../../../../.. | Progress: resolved 692, reused 454, downloaded 1, added 0
../../../../.. | Progress: resolved 693, reused 454, downloaded 1, added 0
../../../../.. | Progress: resolved 793, reused 636, downloaded 3, added 0
../../../../.. | Progress: resolved 793, reused 637, downloaded 3, added 0
../../../../.. | Progress: resolved 1045, reused 937, downloaded 4, added 0
../../../../.. | Progress: resolved 1046, reused 937, downloaded 4, added 0
../../../../.. | Progress: resolved 1299, reused 1277, downloaded 4, added 0
../../../../.. | Progress: resolved 1300, reused 1277, downloaded 4, added 0
../../../../.. | Progress: resolved 1701, reused 1697, downloaded 4, added 0
../../../../.. | Progress: resolved 1702, reused 1697, downloaded 4, added 0
WARN [email protected] requires a peer of @unimodules/core@* but none was installed.
WARN [email protected] requires a peer of expo-asset@* but none was installed.
WARN [email protected] requires a peer of unimodules-permissions-interface@* but none was installed.
WARN expo-cli > xdl > @expo/webpack-config: @pmmmwh/[email protected] requires a peer of type-fest@^0.13.1 but version 0.5.2 was installed.
../../../../.. | Progress: resolved 1789, reused 1785, downloaded 4, added 0
../../../../.. | +8 +
../../../../.. | Progress: resolved 1789, reused 1785, downloaded 4, added 1
../../../../.. | Progress: resolved 1789, reused 1785, downloaded 4, added 6, done
WARN Failed to find "/win-dpapi/0.1.1" in lockfile during hoisting. Next aliases will not be hoisted: win-dpapi
WARN 1 other warnings
WARN 2 other warnings
WARN 3 other warnings
WARN 4 other warnings
WARN 5 other warnings
WARN 6 other warnings
WARN 7 other warnings
WARN 8 other warnings
WARN 9 other warnings
WARN 10 other warnings
WARN 11 other warnings
Cannot link binary 'expo' of 'expo-cli' to '/xxx/mobile/node_modules/.bin': binary of 'expo' is already linked
dependencies:
+ expo-av 9.0.0
I would suggest adding a big warning to the bottom:
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
+ Your are missing peer deps. You must install them or else... +
+ pnpm add @unimodules/core@* expo-asset@*
+
+ If you want to not see this message again, add these two `ignorePeers`
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
missing peer dependencies:
! @unimodules/core@*
! expo-asset@*
! unimodules-permissions-interface@
Also proposing some kind of ignorePeers setting in npmrc or something that indicates that you don't want the warning to show and that you are happy with the peer range. This is related to strict-peer-dependencies feature.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Related: #827
I would suggest changing the way that missing peers are reported.
Below is an example of the terminal output when I add a dependency.
Note that the missing peers are mixed in with the other log messages higher up such that they are not obvious.
In an IDE (VSCode/WebStorm), usually you only see 10 or so lines in the terminal as it is used as a bottom panel.
I would suggest adding a big warning to the bottom:
Also proposing some kind of
ignorePeers
setting in npmrc or something that indicates that you don't want the warning to show and that you are happy with the peer range. This is related tostrict-peer-dependencies
feature.Beta Was this translation helpful? Give feedback.
All reactions