You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm working on a monorepo which is currently using pnpm@8 and everything works fine.
Right now I'm trying to upgrade to pnpm@v9.
I installed [email protected] on my system, and ran pnpm i.
In one of the monorepo's apps, when I tried to run eslint I got some weird errors:
...
...
/Users/antonisprovidakis/projects/ui/apps/people-search/support/webpack/sprite.js
0:0 error Parsing error: require() of ES Module /Users/antonisprovidakis/projects/ui/node_modules/.pnpm/[email protected]/node_modules/eslint-scope/lib/definition.js from /Users/antonisprovidakis/projects/ui/node_modules/.pnpm/[email protected][email protected]/node_modules/babel-eslint/lib/require-from-eslint.js not supported.
Instead change the require of definition.js in /Users/antonisprovidakis/projects/ui/node_modules/.pnpm/[email protected][email protected]/node_modules/babel-eslint/lib/require-from-eslint.js to a dynamic import() which is available in all CommonJS modules
✖ 844 problems (844 errors, 0 warnings)
This is the content (part of it) of the package.json file:
Is somehow the public-hoist-pattern[]=*eslint* related?
I thought that public-hoist-pattern affects phantom dependencies, which in my case does not make sense, since I've been explicit on the packages/versions I need.
Maybe something else is wrong?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
pnpm
-
I'm working on a monorepo which is currently using
pnpm@8and everything works fine.Right now I'm trying to upgrade to
pnpm@v9.I installed
[email protected]on my system, and ranpnpm i.In one of the monorepo's apps, when I tried to run
eslintI got some weird errors:This is the content (part of it) of the
package.jsonfile:{ "name": "foo", "version": "0.0.0", "scripts": { ... "lint": "eslint .", }, "dependencies": { "@babel/polyfill": "7.4.3", "@babel/runtime": "7.4.3", "classnames": "2.2.3", "clsx": "2.1.1", "create-react-class": "15.6.0", "date-fns": "2.29.3", "deep-extend": "0.6.0", "draft-js": "0.10.5", "escape-string-regexp": "1.0.5", "extend": "3.0.2", "google-maps": "3.2.1", "gulp-rename": "2.0.0", "gulp-s3-upload": "1.7.3", "hammerjs": "2.0.8", "html-react-parser": "1.2.4", "jquery": "3.6.4", "jquery-highlight": "3.4.0", "jwt-decode": "2.2.0", "keymirror": "0.1.1", "localstorage-memory": "1.0.2", "lodash": "4.17.21", "number-abbreviate": "1.2.1", "pdfjs-dist": "2.14.305", "pluralize": "4.0.0", "pollUntil": "1.0.3", "prelude-extension": "0.1.0", "prop-types": "15.7.2", "query-string": "7.0.0", "react": "16.14.0", "react-addons-css-transition-group": "15.6.0", "react-addons-pure-render-mixin": "15.6.2", "react-addons-shallow-compare": "15.5.2", "react-dom": "16.14.0", "react-dom-factories": "1.0.2", "react-flip-move": "2.7.3", "react-lazily-render": "1.0.1", "react-pencil": "1.1.1", "react-redux": "5.0.4", "react-select": "1.2.1", "react-transition-group": "1.2.0", "react-visibility-sensor": "3.11.0", "redux": "3.5.2", "redux-logger": "3.0.6", "redux-notify": "0.2.0", "redux-persist": "4.8.2", "redux-thunk": "2.1.0", "rollbar": "2.26.0", "socket.io-client": "2.1.0", "tether": "1.1.1", "underscore": "1.13.6", "underscore-deep-extend": "1.1.5", "underscore.string": "3.3.6", "universal-analytics": "0.4.15", "uuid": "3.0.1", "visibilityjs": "1.2.4", "worker-loader": "3.0.8" }, "devDependencies": { "@babel/core": "7.4.3", "@babel/plugin-proposal-class-properties": "7.4.0", "@babel/plugin-proposal-optional-chaining": "7.6.0", "@babel/plugin-syntax-dynamic-import": "7.2.0", "@babel/plugin-transform-modules-commonjs": "7.2.0", "@babel/plugin-transform-regenerator": "7.4.3", "@babel/plugin-transform-runtime": "7.4.3", "@babel/preset-env": "7.4.3", "@babel/preset-react": "7.0.0", "@babel/register": "7.4.0", "@babel/runtime": "7.4.3", "@babel/runtime-corejs3": "7.7.2", "@testing-library/jest-dom": "5.16.5", "@testing-library/react": "12.1.2", "@testing-library/react-hooks": "8.0.1", "@testing-library/user-event": "13.5.0", "@types/jest": "24.9.1", "@types/node": "14.17.34", "autoprefixer": "9.2.1", "babel-core": "7.0.0-bridge.0", "babel-eslint": "10.0.1", "babel-jest": "25.5.1", "babel-loader": "8.0.4", "babel-plugin-istanbul": "4.1.4", "babel-plugin-module-resolver": "3.2.0", "babel-plugin-react-transform": "2.0.2", "cache-loader": "1.2.5", "chai": "4.0.2", "chai-as-promised": "7.1.1", "css-hot-loader": "1.4.4", "css-loader": "1.0.1", "cssnano": "4.1.0", "del": "3.0.0", "domready": "1.0.8", "dotenv": "7.0.0", "enzyme": "3.9.0", "enzyme-adapter-react-16": "1.5.0", "enzyme-to-json": "3.3.1", "eslint": "7.15.0", "eslint-config-prettier": "5.1.0", "eslint-loader": "4.0.2", "eslint-plugin-babel": "5.3.0", "eslint-plugin-jest": "22.4.1", "eslint-plugin-react": "7.4.0", "eslint-plugin-react-hooks": "2.0.1", "eslint-plugin-sonarjs": "0.23.0", "extract-text-webpack-plugin": "3.0.0", "file-loader": "2.0.0", "git-revision-webpack-plugin": "3.0.3", "gulp": "4.0.2", "gulp-cache": "0.5.0", "gulp-env": "0.4.0", "gulp-filenames": "4.0.1", "gulp-git": "2.5.0", "gulp-if": "2.0.0", "gulp-imagemin": "4.1.0", "gulp-json-editor": "2.2.1", "gulp-livereload": "3.8.1", "gulp-load-plugins": "1.2.0", "gulp-replace-task": "0.11.0", "gulp-rollbar": "0.1.4", "gulp-serve": "1.4.0", "gulp-shell": "0.6.5", "gulp-sourcemaps": "2.6.3", "gulp-util": "3.0.7", "gulp-zip": "4.1.0", "gulp4-run-sequence": "1.0.1", "html-webpack-plugin": "5.1.0", "husky": "8.0.1", "image-webpack-loader": "4.6.0", "jest": "25.5.4", "jest-cli": "24.7.1", "jest-junit": "6.3.0", "jest-sonar-reporter": "2.0.0", "jest-webextension-mock": "3.8.9", "jsdom": "21.1.1", "json-loader": "0.5.4", "jsonwebtoken": "9.0.0", "lint-staged": "13.0.3", "mini-css-extract-plugin": "1.6.2", "minimist": "1.2.8", "natives": "1.1.6", "node-sass": "9.0.0", "node-slack": "0.0.7", "npm-install-webpack-plugin": "4.0.5", "nyc": "11.4.1", "opn": "5.0.0", "postcss-cssnext": "3.0.2", "postcss-custom-properties": "9.0.2", "postcss-import": "11.0.0", "postcss-loader": "3.0.0", "postcss-scss": "2.0.0", "prettier": "3.2.5", "prettier-eslint": "16.3.0", "prettier-eslint-cli": "8.0.1", "react-addons-test-utils": "15.2.1", "react-hot-loader": "4.8.2", "react-test-renderer": "16.8.6", "redux-freeze": "0.1.5", "redux-mock-store": "1.5.3", "regenerator-runtime": "0.13.2", "request": "2.79.0", "request-promise": "4.2.4", "resize-observer-polyfill": "1.5.1", "sass-loader": "10.5.2", "sinon": "2.2.0", "sinon-chai": "2.14.0", "sinon-chrome": "2.2.1", "sinon-stub-promise": "4.0.0", "sinon-test": "1.0.1", "source-map-loader": "1.1.3", "style-loader": "0.23.1", "svg-baker-runtime": "1.4.7", "svg-sprite-loader": "6.0.11", "ts-jest": "26.5.6", "ts-loader": "8.4.0", "typescript": "5.4.4", "uglifyjs-webpack-plugin": "2.2.0", "url-loader": "1.1.2", "webpack": "5.92.1", "webpack-bundle-analyzer": "4.10.1", "webpack-glob-entries": "1.0.1", "webpack-merge": "5.7.3", "webpack-query-loader": "2.0.5", "webpack-monitor": "1.0.13" } }Also, this is the content of the
.npmrcfile located at the root of the monorepo:On the error printed when I ran eslint (see at the top), you can see that:
are used. Which is wrong, as package.json includes:
Obviously,
[email protected]and[email protected]are installed on other apps of the monorepo (but not in this one).Node seems to resolve modules just fine:
Is somehow the
public-hoist-pattern[]=*eslint*related?I thought that
public-hoist-patternaffects phantom dependencies, which in my case does not make sense, since I've been explicit on the packages/versions I need.Maybe something else is wrong?
Please help.
cc @zkochan
Beta Was this translation helpful? Give feedback.
All reactions