You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tabs permission will add a warning of Read your browsing history, that's because I can listen to chrome.tabs.onUpdate and record the active browser history, from now on.
I see the best practice is to use activeTab, we should check if we can use it instead of tabs.
You need to change the tab permission on the manifest files to activeTab.
Overlay is accessing all tabs when the user changing the settings from the Popup, but changing the permission will break it.
Instead, we need to use tabs.onActivated to actively check if the setting changed when a tab becomes active.
Also, check other usages of browser.tabs are not broken.
The text was updated successfully, but these errors were encountered:
A quick research gave me this information:
The
tabs
permission will add a warning of Read your browsing history, that's because I can listen tochrome.tabs.onUpdate
and record the active browser history, from now on.I see the best practice is to use
activeTab
, we should check if we can use it instead oftabs
.Links:
overlay/src/manifest.chrome.json
Line 40 in bda5fc7
Chrome extension tabs permissions shows "Read your browsing history"
The
tabs
warningUse the
activeTab
permissionOriginally posted by @baruchiro in #145 (comment)
What to do
You need to change the
tab
permission on the manifest files toactiveTab
.Overlay is accessing all tabs when the user changing the settings from the Popup, but changing the permission will break it.
Instead, we need to use
tabs.onActivated
to actively check if the setting changed when a tab becomes active.Also, check other usages of
browser.tabs
are not broken.The text was updated successfully, but these errors were encountered: