Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for git@github in dependencies for schema generation #270

Open
haavardeide opened this issue Oct 14, 2024 · 2 comments
Open

Support for git@github in dependencies for schema generation #270

haavardeide opened this issue Oct 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@haavardeide
Copy link
Contributor

If a dependency is referenced with git@github release location instead of a relative reference ../versions, then schema generation will fail.

Solution: ensure that schema generation will work with both relative and github release:

  dependencies:
    - name: versions
      template-url: "[email protected]:oslokommune/golden-path-boilerplate//boilerplate/terraform/versions?ref=versions-v3.0.6"
  dependencies:
    - name: versions
      template-url: "../versions"
@haavardeide haavardeide added the bug Something isn't working label Oct 14, 2024
@haavardeide haavardeide self-assigned this Oct 14, 2024
@staticaland
Copy link
Contributor

Schema generation should never make a main command to fail.

This could be decoupled from the CLI by hosting the schemas over HTTP.

@haavardeide haavardeide removed their assignment Nov 4, 2024
@falense
Copy link
Contributor

falense commented Nov 4, 2024

Når man kjører ok pkg install så kræsjer den fordi den ikke støtter remote reference (kun lokal path)

@haavardeide haavardeide self-assigned this Nov 6, 2024
@haavardeide haavardeide removed their assignment Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants