Pane-based layout for the OKR timeline view #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
petterhj
commented
Aug 25, 2023
petterhj
commented
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
simenheg
reviewed
Aug 28, 2023
src/components/ProgressBar.vue
Outdated
| @@ -1,51 +1,127 @@ | |||
| <template> | |||
| <div v-tooltip="label" class="progress"> | |||
| <progress max="100" :value="Math.min(progression, 100)" :aria-label="label" /> | |||
| <div class="progress-bar"> | |||
There was a problem hiding this comment.
Hvorfor gå bort fra å bruke <progress>-elementet?
petterhj
force-pushed
the
three-pane-okrs
branch
from
1fa4000
to
c2d7de2
Compare
Support objective lifting
Filter ownerOptions on keyResult
More tress adjustments
Remove useless conditional check (`user` would always evaluate to `true`; it is checked earlier in the same function).
Fix CodeQL warning about useless conditional
Fix sub KPI bindings
Make users able to create objective contributors for objectives on their item's parent item (🤯).
More objective contributors Firestore rule tweaks
Timeline interaction fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.