Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create/edit/delete rights for org admins #845

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

simenheg
Copy link
Collaborator

Fix several bugs in the isAdminOfParent Firestore rule check to make organization admins able to create/edit/delete items within their organizations (again?).

@simenheg simenheg requested a review from a team August 29, 2023 08:57
@simenheg simenheg force-pushed the firebase-rules-fixes branch 3 times, most recently from 67e7111 to 9316827 Compare September 1, 2023 12:05
Fix several bugs in the `isAdminOfParent` Firestore rule check to make
organization admins able to create/edit/delete items within their
organizations (again?).
@simenheg simenheg force-pushed the firebase-rules-fixes branch from 9316827 to 971c3eb Compare September 4, 2023 07:51
Copy link
Collaborator

@petterhj petterhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simenheg simenheg merged commit c2059a0 into main Sep 5, 2023
3 checks passed
@simenheg simenheg deleted the firebase-rules-fixes branch September 5, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants