Include preserveTags in nsi-id-presets.json

[westnordost]

Currently, the preserveTags property is only added to the presets in dist/nsi.json but not to the presets in dist/presets/nsi-id-presets.json.

Since this property should trigger a change in behavior how the preset from the NSI is applied, it should be included in the nsi-id-presets.json, too, even if that property is not mentioned in the schema for presets.

I am using the nsi-id-presets.json in StreetComplete (via the osmfeatures library). It is convenient for me to use these because they are in the same format as the iD presets.

[UKChris-osm]

Does iD not used dist/presets/nsi-id-presets.json?

Could StreetComplete not use dist/nsi.json if this file already includes the preserveTags data? That file seems a lot smaller as well.

[westnordost]

Could StreetComplete not use dist/nsi.json if this file already includes the preserveTags data? That file seems a lot smaller as well.

It is more convenient to use nsi-id-presets.json as it is in the same format as the iD presets and thus does not require to write another parser for that.

[bhousel]

Yeah we can probably do this..

For what it's worth, I'm kind of considering the nsi-id-presets file a bit of a legacy file.
In Rapid (and I guess iD) we fetch both the NSI data files (for the validator) and also the presets file (for the presets) - this redundancy is really unnecessary.

[westnordost]

By the way, and for your information,

Uses nsi-id-presets.json

• iD, Rapid
• Go Map!!
• StreetComplete, SCEE (via osmfeatures library)

Uses nsi.json

• iD, Rapid
• Vespucci
• EveryDoor
• Osmose
• AllThePlaces