Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed item images #108

Open
rynobax opened this issue May 31, 2019 · 4 comments
Open

Add detailed item images #108

rynobax opened this issue May 31, 2019 · 4 comments
Labels
enhancement items Anything to do with the items data, API or builder monsters Anything to do with the monsters data, API or builder planning Anything being planned for future releases

Comments

@rynobax
Copy link

rynobax commented May 31, 2019

I'm working on a OSRS related project, and wanted detailed images of each item (like this). I was hoping this project would have them, but I ended up just scraping them from the wiki. Is that something that could be added to this project? If so I'd be happy to make a PR.

@osrsbox
Copy link
Owner

osrsbox commented May 31, 2019

Hey @rynobax - I can definitely see the use of the detailed images for OSRS items for various community projects. I too have needed, and used these types of images in the past, and having a curated list of them would be really useful (more data/resources the better!). Couple of questions:

  1. Have you got the detailed images linked/saved by item name or item ID or similar?
  2. Have you got complete (or nearly complete) coverage for all items? I try to keep the data in the project complete, but sometimes this is not possible due to lack of supporting data from the game cache or wiki.

I am not sure about hosting the actual item image on this repo. I don't really like hosting the item inventory icons, but they are very commonly used. But maybe a potential solution is to include a URL for each item that points to the OSRS Wiki detailed image URL? So that other community developers can fetch specific images using a script. What do you think?

@osrsbox osrsbox self-assigned this May 31, 2019
@osrsbox osrsbox added enhancement items Anything to do with the items data, API or builder labels May 31, 2019
@rynobax
Copy link
Author

rynobax commented Jun 1, 2019

I was able to get an image for every item traded on the GE, except for 3 that had gif icons (I just wanted pngs). I'll try running the script for all items in this repo and see what the results are.

As for storing urls vs images, I think URLs could work. I'll have to do some investigation into how often wiki images get updated, and if updating the image changes the url.

@osrsbox osrsbox removed their assignment Jan 1, 2020
@gc
Copy link

gc commented Feb 26, 2020

FYI someone called abex in the runelite discord server has the script which generates all the detailed images for the wiki

@osrsbox
Copy link
Owner

osrsbox commented Feb 3, 2021

After a Discord comment, might end up trying to resolve this long open issue by adding the URL of the larger image for items. This could be a new property, called something like wiki_image_url... or similar. For future reference, the image is from the Infobox in the image property:

{{Infobox Item
|name = Abyssal whip
|image = [[File:Abyssal whip.png]]
|release = [[26 January]] [[2005]]
}}

Might even be cool to add the same URL for monsters, as they have the same image property:

{{Infobox Monster
|version1 = Standard
|version2 = Catacombs of Kourend
|name = Abyssal demon
|image1 = [[File:Abyssal demon.png|200px]]
|image2 = [[File:Abyssal demon (Catacombs of Kourend).png|200px]]
|release1 = [[26 January]] [[2005]]
|release2 = [[9 June]] [[2016]]

@osrsbox osrsbox added monsters Anything to do with the monsters data, API or builder planning Anything being planned for future releases and removed help wanted labels Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement items Anything to do with the items data, API or builder monsters Anything to do with the monsters data, API or builder planning Anything being planned for future releases
Projects
None yet
Development

No branches or pull requests

3 participants