-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed item images #108
Comments
Hey @rynobax - I can definitely see the use of the detailed images for OSRS items for various community projects. I too have needed, and used these types of images in the past, and having a curated list of them would be really useful (more data/resources the better!). Couple of questions:
I am not sure about hosting the actual item image on this repo. I don't really like hosting the item inventory icons, but they are very commonly used. But maybe a potential solution is to include a URL for each item that points to the OSRS Wiki detailed image URL? So that other community developers can fetch specific images using a script. What do you think? |
I was able to get an image for every item traded on the GE, except for 3 that had gif icons (I just wanted pngs). I'll try running the script for all items in this repo and see what the results are. As for storing urls vs images, I think URLs could work. I'll have to do some investigation into how often wiki images get updated, and if updating the image changes the url. |
FYI someone called abex in the runelite discord server has the script which generates all the detailed images for the wiki |
After a Discord comment, might end up trying to resolve this long open issue by adding the URL of the larger image for items. This could be a new property, called something like
Might even be cool to add the same URL for monsters, as they have the same
|
I'm working on a OSRS related project, and wanted detailed images of each item (like this). I was hoping this project would have them, but I ended up just scraping them from the wiki. Is that something that could be added to this project? If so I'd be happy to make a PR.
The text was updated successfully, but these errors were encountered: