Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all issue from letsvalidate.com site #103

Open
8 tasks
davydovanton opened this issue Mar 7, 2017 · 3 comments
Open
8 tasks

Pass all issue from letsvalidate.com site #103

davydovanton opened this issue Mar 7, 2017 · 3 comments
Labels
easy enhancement help wanted

Comments

@davydovanton
Copy link
Member

We need pass all issues on https://www.letsvalidate.com/?url=http://www.ossboard.org.

  • Meta description not found or empty.
  • Character set not found.
  • <html> tag should have an explicit lang attribute.
  • App icons for mobile devices not found.
  • Site map(s) not found at http://www.ossboard.org/sitemap.xml.
  • Content is not gzipped.
  • At least one of og:url, og:title, og:description, and og:image meta properties is missing.
  • At least one of twitter:card, twitter:title, twitter:description, and twitter:image meta properties is missing.
@davydovanton davydovanton changed the title Pass all issue on letsvalidate.com site Pass all issue from letsvalidate.com site Mar 7, 2017
@morrme
Copy link
Contributor

morrme commented Mar 27, 2017

I am new but I'd like to help. I think I've located the solutions for most of these.

@davydovanton
Copy link
Member Author

@morrme awesome, if you have any questions feel free to ask 👍

@morrme
Copy link
Contributor

morrme commented Mar 27, 2017

Sure. So far:

  • The meta tags can be created with the og: tags , and I can get that from the current info on the site.

  • I can use /apps/web/assets/images/header-logo.png for the og:image tag (and twitter:image ) if that works for you.

  • The character set and lang attributes are quick edits

  • A site map can be generated via a web tool like https://www.xml-sitemaps.com/ .

  • Do you have a preferred app icon? Perhaps a larger version of the favico?

This was referenced Aug 22, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davydovanton @morrme