-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Devops] Run metrics job from forks #1113
base: main
Are you sure you want to change the base?
Conversation
Closed #910 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 41 41
Lines 5355 5355
=======================================
Hits 4724 4724
Misses 631 631 ☔ View full report in Codecov by Sentry. |
Note: This pr does not fully fix the problem of the metrics job failing when executed from a forked repository. Github requires the agent to be logged in when commenting on pull requests of another repository. However, this pr provides a cleaner implementation of commenting to pull requests when executed from a branch within the main repository. Therefore I would recommend to merge this pr now and create a seperate pr when the metrics job should also succeed in forked repositories. |
🔬 Background
🔮 Key changes
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.