Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on pypi #1733

Closed
remcohaszing opened this issue Feb 29, 2020 · 2 comments
Closed

Publish on pypi #1733

remcohaszing opened this issue Feb 29, 2020 · 2 comments

Comments

@remcohaszing
Copy link

I want to use minecraft overviewer a try on Ubuntu 19.10 and ran into #1595.

I tried installing it using pipx.

sudo apt install pipx
pipx install pipx  # upgrade for git repository support
pipx install git+https://github.com/overviewer/Minecraft-Overviewer.git

However this failed, because setup.py depends on numpy.


Could you publish this package on pypi as wheels for various Python versions and an sdist? This way all standard Python tooling can work with it. I.e.:

pip install --user minecraft-overviewer
pipx install minecraft-overviewer
pipenv install minecraft-overviewer
poetry add minecraft-overviewer

This would also fix support for unsupported platforms, offering a nice workaround for #1595. pipx can be mentioned as a platform independent installation method in the readme.

@enaut
Copy link
Contributor

enaut commented Feb 29, 2020

it is way easier to install numpy using apt (numpy is a general library and not part of overviewer):

sudo apt install python3-numpy 

Also there is a ubuntu package of overviewer: https://overviewer.org/downloads

Also see the build instructions:
http://docs.overviewer.org/en/latest/building/#linux

@CounterPillow
Copy link
Member

We won't do this because the C extension depends on non-public Pillow headers which most distros ship but pypi doesn't ship, so automatically building from source with pip et al wouldn't work. Furthermore, if someone had the time to add automated wheel builds (which would require us to build against ancient versions of libc because someone might be running some ancient RHEL or whatever, ew) they could just as well simply fix the debian repos to build things for different versions of python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants