Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"RecursionError: maximum recursion depth exceeded" since upgrading to 1.19.3 #2076

Closed
BenKennish opened this issue Dec 12, 2022 · 3 comments
Closed

Comments

@BenKennish
Copy link

I upgraded Minecraft to 1.19.3 and overviewer will no longer render my world...

overviewer.py:371  6256 2022-12-12 02:11:58 INFO     Welcome to Minecraft Overviewer version 0.19.44 (cabcdf9)!
overviewer.py:504  6256 2022-12-12 02:11:58 INFO     Generating textures...
*******************************************************************************
overviewer.py:663  6256 2022-12-12 02:12:20 ERROR    An error has occurred. This may be a bug. Please let us know!
See http://docs.overviewer.org/en/latest/index.html#help

This is the error that occurred:
Traceback (most recent call last):
  File "/opt/minecraft/server/../tools/overviewer/overviewer.py", line 653, in <module>
    ret = main()
  File "/opt/minecraft/server/../tools/overviewer/overviewer.py", line 505, in main
    tex.generate()
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 145, in generate
    tex = texgen(self, blockid, data)
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 1218, in func_wrapper
    return func(texobj, blockid, data)
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 1257, in inner_block
    return self.build_block_from_model(name)
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 940, in build_block_from_model
    self.draw_blockface(img, elem, colmodel, blockstate, modelname, 'north')
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 969, in draw_blockface
    texture = self.build_texture(direction, elem, colmodel, blockstate, modelname, facing)
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 1061, in build_texture
    elem['faces'][textureface]['texture'], data['textures']).copy()
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 1186, in find_texture_from_model
    return self.find_texture_from_model(textureset[face[1:]], textureset)
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 1186, in find_texture_from_model
    return self.find_texture_from_model(textureset[face[1:]], textureset)
  File "/opt/minecraft/tools/overviewer/overviewer_core/textures.py", line 1186, in find_texture_from_model
    return self.find_texture_from_model(textureset[face[1:]], textureset)
  [Previous line repeated 989 more times]
RecursionError: maximum recursion depth exceeded
@BenKennish BenKennish changed the title RecursionError: maximum recursion depth exceeded since upgrading to 1.19.3 "RecursionError: maximum recursion depth exceeded" since upgrading to 1.19.3 Dec 12, 2022
@BenKennish
Copy link
Author

How would i go about trying to debug this? I cannot render a world map anymore and the players on my server are missing being able to view one 😢

Is overviewer working on 1.19.3 worlds for anyone else?

@vilhok
Copy link

vilhok commented Dec 16, 2022

How would i go about trying to debug this?

  • Can you render another, different map?
  • What if you delete the whole render and start over?
  • Are you running the overviewer from a computer with minecraft 1.19.3 installed and textures available? Maybe you only have 1.19.2. on the machine you are rendering on.

This is how I would start. By looking at the code line, it seems to crash on the recursive method that tries to find textures. Try reinstalling textures/correct version of minecraft.

@BenKennish
Copy link
Author

See #2046 - i was using a fork that has a bug with 1.19.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants