-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Comment Reporter - marker not unique, message is overwritten in monorepo context #3068
Comments
@ancosma i'd be delighted to validate such PR, thanks for your offer :) |
@ancosma, we have historically preferred introducing a fallback option to introducing a breaking change. Can you explain why the fallback option would be needed to avoid a breaking change in this case though? |
If the directory is root, the marker value must remain the same, to avoid a breaking change |
Oh, I see; I was taking that for granted. Yes, that seems like the correct path to me. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
Describe the bug
When used in the context of monorepo and a single PR, we run same workflow multiple time. Each time the working directory we pass to megalinter is a different one. Because megalinter uses only GITHUB_WORKFLOW and GITHUB_JOB it will overwrite the message created by previous run of the megalinter for other directories.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Because we run same workflow but on different folders, we expect to get 2 comments each reporting for the folder in which megalinter ran.
P.S.:
In order to make the marker unique, it should include the directory in which megalinter ran.
In case you agree with the change, I can create a PR which fixes the issue. Should it be a breaking change or first try to identify the message using the old marker (without directory included) and then try with the marker which uses the directory?
The text was updated successfully, but these errors were encountered: