Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dump whole Syft initial output file to console at debug log level #4288

Open
sanmai-NL opened this issue Nov 19, 2024 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@sanmai-NL
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When running at log level DEBUG, the Syft checker stands out for its needless verbosity.

At

logging.debug("SYFT initial output file: " + json_file_str)
the whole output file is logged.

Describe the solution you'd like
Stop dumping the whole output file to console. It is already available through the SARIF reporter.

Describe alternatives you've considered

Additional context

@sanmai-NL sanmai-NL added the enhancement New feature or request label Nov 19, 2024
@nvuillam
Copy link
Member

@sanmai-NL agreed :)
Would you like to make a PR ?

@sanmai-NL
Copy link
Contributor Author

sanmai-NL commented Nov 23, 2024

@nvuillam I didn't yet, to await discussion. It seems you see my point. But how to improve this? Simply removing the line is a possibility. I don't know who's using this and why.

@nvuillam
Copy link
Member

@sanmai-NL probably me when I was setting up the linter :)

You can remove it ^^

@nvuillam
Copy link
Member

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 24, 2024
@sanmai-NL
Copy link
Contributor Author

Not stale.

@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants