Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance type of app.config #313

Closed
wants to merge 4 commits into from
Closed

Fix instance type of app.config #313

wants to merge 4 commits into from

Conversation

jichengzhi
Copy link

@jichengzhi jichengzhi commented Jan 5, 2024

I fixed the issue by overriding the class attribute declaration of quart.app.config_class.

Sorry that I'm confused with doc updates and don't know what to do. I think I do not need to update CHANGES.rst and .. versionchanged:: related sections.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@aenglander
Copy link

Will this break backwards compatibility for those who have already used the workaround? Does it matter?

@jichengzhi jichengzhi closed this Jan 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load QUART_ prefixed environment variables
2 participants