Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Quart's default_config on Flask's #378

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Base Quart's default_config on Flask's #378

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
323bf72
Let Quart.default_config take all k/v pairs from flask.app.Flask.defa…
JamesParrott Nov 14, 2024
9c62bf2
Run isort
JamesParrott Nov 14, 2024
aa5001e
Add Flask to app.py namespace, (adjust import style to from flask.app…
JamesParrott Nov 15, 2024
9c7973c
Run isort
JamesParrott Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/quart/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
)
from urllib.parse import quote

import flask.app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use from flask import Flask here. Long term, maybe DEFAULT_CONFIG should be defined outside Flask so it can be shared more easily.

from aiofiles import open as async_open
from aiofiles.base import AiofilesContextManager
from flask.sansio.app import App
Expand Down Expand Up @@ -235,7 +236,8 @@ class Quart(App):
websocket_class = Websocket

default_config = ImmutableDict(
{
flask.app.Flask.default_config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably clean up config keys from here that aren't used anymore or don't change the default.

| {
"APPLICATION_ROOT": "/",
"BACKGROUND_TASK_SHUTDOWN_TIMEOUT": 5, # Second
"BODY_TIMEOUT": 60, # Second
Expand Down