Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try sphinx 6.2.1 #593

Closed
wants to merge 1 commit into from
Closed

Try sphinx 6.2.1 #593

wants to merge 1 commit into from

Conversation

cisaacstern
Copy link
Member

Dependabot keeps suggesting we upgrade sphinx (e.g. #592), and docs builds lately fail on those PRs, so I've been closing them.

I know we can have Dependabot ignore sphinx upgrades, but before we do that, I wanted to see if we can bump to this version, because we admittedly are on a quite old sphinx version currently.

I've chosen 6.2.1 because its the latest version in the 6.. series, and our base theme, sphinx-book-theme, supports <7.

Presumably the first build will fail here due to incompatibility with other pinned docs requirements. I'll clean that up in a follow-on commit here.

@cisaacstern
Copy link
Member Author

This is failing with

The conflict is caused by:
    The user requested sphinx==6.2.1
    pangeo-sphinx-book-theme 0.2 depends on sphinx
    myst-parser 0.13.6 depends on sphinx<4 and >=2

so seems like it would require a fix in https://github.com/pangeo-forge/pangeo-sphinx-book-theme/

@cisaacstern
Copy link
Member Author

so seems like it would require a fix in https://github.com/pangeo-forge/pangeo-sphinx-book-theme/

I misunderstood the error. Deeper dive on this locally leaves me to conclude that myst-nb/myst-parser interactions are a bit of a blocker here, so I think we should pause on this until #569 is complete, at which point I think we can drop myst-nb.

@cisaacstern
Copy link
Member Author

Closing as a failed experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant