Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backing: improve session buffering for runtime information #6284

Merged
merged 10 commits into from
Nov 13, 2024
Merged

backing: improve session buffering for runtime information #6284

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77c71c6
feat(backing): add session buffering for validator list
sw10pa Oct 30, 2024
4d8dd50
refactor, feat(backing): split caching logic into separate struct, ad…
sw10pa Nov 4, 2024
22f274f
refactor(backing): refactor caching functions and update usages
sw10pa Nov 6, 2024
4f29762
feat(backing): replace runtime API call for retrieving node features …
sw10pa Nov 8, 2024
830166a
feat(backing): add caching for executor_params
sw10pa Nov 11, 2024
4b1f371
refactor(backing): use direct runtime API to get executor_params and …
sw10pa Nov 11, 2024
bbe25d4
refactor(subsystem-util): rollback changes
sw10pa Nov 11, 2024
4a7c946
Merge branch 'master' into sw10pa/backing-session-buffering
sw10pa Nov 11, 2024
74fc6d6
docs(prdoc): add prdoc for PR #6284
sw10pa Nov 11, 2024
f7898b7
refactor(backing): change error and caching function names
sw10pa Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions polkadot/node/core/backing/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ pub enum Error {

#[error("Availability store error")]
StoreAvailableData(#[source] StoreAvailableDataError),

#[error("Data is not available")]
DataNotAvailable,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't say anything

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a temporary solution, I have changed the name and description of the error but, as discussed separately, will try to replace RuntimeApiErrors with Subsystem errors in a separate PR.

}

/// Utility for eating top level errors and log them.
Expand Down
Loading
Loading