-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dmp: Check that the para exist before delivering a message #6604
base: master
Are you sure you want to change the base?
Conversation
/cmd prdoc --audience runtime_dev --bump patch |
for those failed rococo/westend benchmarks, for |
there is also one place: https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/hrmp.rs#L1886-L1898, I am not sure if this new
|
let me fix this for you |
I already have it fixed locally :) Just need to fix more :D |
:D :D nice, so at least please consider one small clean-up of my older code: #6714 |
#[cfg(feature = "runtime-benchmarks")] | ||
fn ensure_successful_delivery(location: Option<Location>) { | ||
if let Some((0, [Parachain(id)])) = location.as_ref().map(|l| l.unpack()) { | ||
dmp::Pallet::<T>::make_parachain_reachable(*id); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍, I think we could now add this to ParentAsUmp
, XcmpQueue
and maybe it will simplify and deduplicate other stuff - I can take a look as a follow-up
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
bot fmt |
@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7888261 was started for your command Comment |
@bkchr Command |
/cmd prdoc --audience runtime_dev --bump major |
Command "prdoc --audience runtime_dev --bump major" has failed ❌! See logs here |
/cmd prdoc --audience runtime_dev --bump major --force |
All GitHub workflows were cancelled due to failure one of the required jobs. |
No description provided.